search

Algo-Phantoms / Algo-ScriptML

Scripts of Machine Learning Algorithms from Scratch. Implementations of machine learning models and algorithms using nothing but NumPy with a focus on accessibility. Aims to cover everything from basic to advance.
MIT License
90 stars 66 forks source link

Cross-Validation-from-Scratch #114 #166

Closed Dishita2602 closed 3 years ago

Dishita2602 commented 3 years ago

I have code for 4 methods involved for cross validation. Leave One Out (Linear Reg) Leave P Out (Linear Reg) K fold (Log Reg) K Stratifiedfold (Log Reg)

Please review it.

(Sorry it's issue #114 )

ashwani-rathee commented 3 years ago

Not a class type implementation, @Dishita2602 Please add a class type implementation

Dishita2602 commented 3 years ago

Not a class type implementation, @Dishita2602 Please add a class type implementation

Can you please be more clearer ?

geekquad commented 3 years ago

Hey @Dishita2602, please go through the Contributing Guidelines. We need a class-type implementation of the algorithm/technique from scratch using nothing but NymPy. No external modules/libraries are allowed. To know more about classes in Python please refer here.

Dishita2602 commented 3 years ago

Hey @Dishita2602, please go through the Contributing Guidelines. We need a class-type implementation of the algorithm/technique from scratch using nothing but NymPy. No external modules/libraries are allowed. To know more about classes in Python please refer here.

Issue was not created by me so I was not knowing that you guys are only looking for cross-validation implementation without any libraries. Also I had commented in issue that I am going to use these 4 methods but nobody replied to it. That's why I did PR as per my understanding.

geekquad commented 3 years ago

Hey @Dishita2602, please go through the Contributing Guidelines. We need a class-type implementation of the algorithm/technique from scratch using nothing but NymPy. No external modules/libraries are allowed. To know more about classes in Python please refer here.

Issue was not created by me so I was not knowing that you guys are only looking for cross-validation implementation without any libraries. Also I had commented in issue that I am going to use these 4 methods but nobody replied to it. That's why I did PR as per my understanding.

Hey @Dishita2602, we might have missed that, apologies. But we have mentioned everything in the Contributing Guidelines. Please make the amendments in the current code-base. Thank you.

geekquad commented 3 years ago

Hey @Dishita2602, you willing to complete it?

ashwani-rathee commented 3 years ago

This doesn't follow the contributing guidelines mentioned and PR creatrr is inactive. Hence closing this PR