search

Algo-Phantoms / Algo-Tree

Algo-Tree is a collection of Algorithms and data structures which are fundamentals to efficient code and good software design. Creating and designing excellent algorithms is required for being an exemplary programmer. It contains solutions in various languages such as C++, Python and Java.
MIT License
361 stars 621 forks source link

Brian Kernighan's Algorithm (Count no of Set Bits) #44

Closed debanjan-2002 closed 3 years ago

debanjan-2002 commented 3 years ago

Sir, I have made an extensive C++ file for Brian Kernighan's algorithm. I have explained the intuition and idea of the algorithm briefly. I have made a pull request regarding the same. Please review my request and if you feel that it is worth it, then please merge it. Link to PR- https://github.com/Algo-Phantoms/Algo-Tree/pull/43 @plazzy99 @rudrakshi99 @nakul-19

I have been selected for GSSOC'21, and I am really interested in DSA, so I would like to contribute in this amazing repository. Regards, Debanjan Poddar

debanjan-2002 commented 3 years ago

Sir, I have added SIEVE OF ERATOSTHENES code in C++. I have written it briefly, explaining each and every step and also added some test cases. It would be really nice of you if you review my pull request. Also, previously I had added BRIAN KERNIGHAN'S algorithm, which is yet to be reviewed by you. It would be really nice of you if you check my PR and if you think it is worth it, then consider merging it. @plazzy99 @rudrakshi99 @nakul-19

Link to Pull Request (PR) - #43

Regards, Debanjan Poddar

1vivekanand commented 3 years ago

Hello @rudrakshi99 @nakul-19 @plazzy99 I am a GSSOC'21 participant I would like to contribute in this issue : Brian Kernighan's Algorithm My language of code will be java with proper comment for better understanding. I will add 2-3 testcases. I will explain the time and space complexity of my approach

vatsalkesarwani12 commented 3 years ago

Sir, I have added SIEVE OF ERATOSTHENES code in C++. I have written it briefly, explaining each and every step and also added some test cases. It would be really nice of you if you review my pull request. Also, previously I had added BRIAN KERNIGHAN'S algorithm, which is yet to be reviewed by you. It would be really nice of you if you check my PR and if you think it is worth it, then consider merging it. @plazzy99 @rudrakshi99 @nakul-19

Link to Pull Request (PR) - #43

Regards, Debanjan Poddar

Link your pull request to this issue by using #

debanjan-2002 commented 3 years ago

SIR, I HAVE LINKED THE PR. Please review it. I have written a brief code. Regards, Debanjan Poddar

debanjan-2002 commented 3 years ago

Sir I have made the changes as stated by you and have made a new pull request. Link to PR #208 It fixes this issue. Fixes - #43 Regards, Debanjan Poddar

1vivekanand commented 3 years ago

Sir, I have Made the PR #218 it fixes the issue #44 Regards. Vivekanand Bhardwaj

ghost commented 3 years ago

Hey! @plazzy99 @rudrakshi99 @nakul-19 I am GSSOC21 participant. I would like to contribute to this issues. I will implement Brian Kernighan's Algo in C++ with adding proper comments. Can you please assign me this issue.

shahina-bano commented 3 years ago

I will solve this problem using python, please assign me.

1vivekanand commented 3 years ago

Sir, I have made the PR #1243 it fixes the issue #44 Regards Vivekanand Bhardwaj

nikhv commented 3 years ago

@tarun26091999 ,please assign this issue to me , I will implement it in c++

nikhv commented 3 years ago

@raksha009 ,please assign this issue to me .I will implement it in c++.

raksha009 commented 3 years ago

@raksha009 ,please assign this issue to me .I will implement it in c++.

The issue is already assigned in cpp. Plz look for other issues :)