Disambiguate key descriptor processing

Algo-Web / POData-Laravel

Composer Package to provide Odata functionality to Laravel

MIT License

34 stars 29 forks source link

Disambiguate key descriptor processing #163

Closed CyberiaResurrection closed 6 years ago

CyberiaResurrection commented 6 years ago

When tables are joined, there's a risk of columns, especially commonly-occuring ones, turning up in at least two tables and thus being ambiguous. This pull request, when processing a KeyDescriptor against an Eloquent model, explicitly and forcibly disambiguates any where clauses it adds to said model.

In no-join case, things proceed as they are now. In join case, ambiguity has been removed.

coveralls commented 6 years ago

Coverage increased (+2.0e-05%) to 99.961% when pulling c27eae8523af9968b434b0d4a56470ff681e431b on CyberiaResurrection:DisambiguateKeyDescriptorProcessing into 491076d2c1385000f99aaa6c3c2b5cfd490474bf on Algo-Web:master.