Algo-Web / POData-Laravel

Composer Package to provide Odata functionality to Laravel
MIT License
34 stars 29 forks source link

Improve integration and fix request #168

Closed NoelDeMartin closed 6 years ago

NoelDeMartin commented 6 years ago

I have tried using this library and there are a couple of things that could be improved, in particular the following:

Other than those improvements above, which you are free to accept or not, there are a couple of fixes as well that I think are critical because they break the integration. Those two are:

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.04%) to 99.923% when pulling 2c8796d5571c8f532700c8c1c1aa3d0dc5bbe87c on NoelDeMartin:master into 94f743401dc37850160270adb1f44bedd1efcebd on Algo-Web:master.

NoelDeMartin commented 6 years ago

Well I just spent 5 minutes for the fixes and 1 hour for the tests, and it's still not accepting the changes so I don't know, let me know what you think -.-.

c-harris commented 6 years ago

Hey, just letting you know I will be reviewing this but am migrating my dev environment so it may take a few days

CyberiaResurrection commented 6 years ago

After real life got in way, this one's now rolled up - thanks @NoelDeMartin !