search

Algo-Web / POData

OData for Poor PHP Devs
Other
28 stars 13 forks source link

kirill533 changes #241

Open c-harris opened 4 years ago

c-harris commented 4 years ago

So I have been going through some of the commits that @kirill533 has made in his fork (based on #240) , some of them are quite elegant. I believe bringing those changes back to upstream would be be mutually beneficial as reducing the differences between his fork and us would reduce the maintance burden on him keeping up to date and would improve our code base.

That said @kirill533 has identifird that his needs may not match ours perfectly so not all commits will be able to come across. As such @CyberiaResurrection as our resident got expert. Can you look at a practical way to cherry pick his commits across into a branch that can then be opened as a pull request. I would like to maintain credit where it is due in the commit structure.

Let me know what you think the best way to-do that would be?

CyberiaResurrection commented 4 years ago

Change of tack - we're instead sneaking up on this bit by bit.