AlgoLab / galig

A graph aligner
GNU General Public License v3.0
26 stars 12 forks source link

Error when testing with example files #9

Open focusonskills opened 4 years ago

focusonskills commented 4 years ago

HI, I encountered the following error when testing with your example data after installation. Do you know what caused the issue and is it caused by inproper installation? Thanks!

File "/opt/galig/asgal", line 54 eprint(f"command: '{' '.join(command)}'") ^ SyntaxError: invalid syntax

ldenti commented 4 years ago

Hi, unfortunately I cannot replicate your error. Can you please tell me:

In the meantime, can you try running the asgal script with python3 asgal [...]? If it's doesn't work, can you try to change the first line of the asgal script from

#!/usr/bin/env python3

to

#!/usr/bin/python3

and the rerun the script on the example data?

focusonskills commented 4 years ago

Hi, I'm using Ubuntu 16.04.4 LTS. Python version is 3.5.2. Running with python3 /directory/to/asgal gives the same error: File "/opt/galig/asgal", line 54 eprint(f"command: '{' '.join(command)}'") ^ SyntaxError: invalid syntax I checked the asgal script and the first line is already #!/usr/bin/python3

Thanks!

On Tue, 23 Jun 2020 at 10:04, Luca Denti notifications@github.com wrote:

Hi, unfortunately I cannot replicate your error. Can you please tell me:

  • your OS
  • the (point) version of python3 you are using
  • how do you invoke asgal: do you run python3 asgal or just ./asgal?

In the meantime, can you try running the asgal script with python3 asgal [...]? If it's doesn't work, can you try to change the first line of the asgal script from

!/usr/bin/env python3

to

!/usr/bin/python3

and the rerun the script on the example data?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AlgoLab/galig/issues/9#issuecomment-648011568, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQBMOJXMVILNFBPZG75ITJ3RYBV2PANCNFSM4OE7R4ZQ .

ldenti commented 4 years ago

Hi, the problem is that f-strings have been introduced in python3.6 (see here). Therefore, the current version of the asgal script cannot work with previous versions of python (thank you for pointing this out, I'll better specify it in the README and the website).

So, if you can use python>=3.6, it would be perfect. Otherwise, I need to translate all the f-strings to the older .format().

Let me know, in case I can provide you a patch or something similar.