Add `group-id` filter to `GET /v2/transactions`

AlgoNode / indexer-api-cdb

searchable history and current state

MIT License

1 stars 0 forks source link

Add `group-id` filter to `GET /v2/transactions` #2

Closed agodnic closed 2 months ago

agodnic commented 2 months ago

Summary

This pull request adds the functionality to search by group ID to GET /v2/transactions. Example:

cusl -Ss 'http://127.0.0.1:8980/v2/transactions?group-id=jtNGL2E2xWqEGkaaWDgxt5HxUcXewzwgpJTFrVHv7Zg='

Test Plan

Tested in a local environment, from a light indexer snapshot.

urtho commented 2 months ago

Nice!

urtho commented 2 months ago

I need to deploy light-indexer to FNet as main indexer API so that everyone can test this functionality.

urtho commented 2 months ago

Just noticed that we follow indexer API convention to use Base64Std instead of Base64URL encoding for URL params.

/ = are not safe for URL.

Somehow it works for other endpoints - like box search. We need a few test cases that include + / = in group_id Base64Std encoded string and see if this works (and why)