AlgoTrader / betfair

Betfair API-NG library for node.js
96 stars 46 forks source link

cannot find module betfair-emulator #23

Closed KieronWiltshire closed 8 years ago

KieronWiltshire commented 8 years ago

Tries to find it at "opt/projects/betfair-emulator", should just be "betfair-emulator", also underscore should be a dependency within the "betfair-emulator" package.

AlgoTrader commented 8 years ago

require was fixed, npm 0.6.6 underscore is NOT a depencency. lodash is

AlgoTrader commented 8 years ago

betfair has hard-coded obsolete version of emulator in packet.json, I fixed it

gRoberts84 commented 8 years ago

When installing 0.6.7 via NPM, both lib/session.js and src/lib/session.js reference the /opts/projects/betfair-emulator package.

//let Emulator = require('betfair-emulator');
var Emulator = require('/opt/projects/betfair-emulator');

However I can see the changes within the repo?

KieronWiltshire commented 8 years ago

@gRoberts84

betfair has hard-coded obsolete version of emulator in packet.json, I fixed it - AlgoTrader

gRoberts84 commented 8 years ago

FYI - The version you've just pushed to NPM no longer works.

The end user will now need to build before they can use it, where as before, it already had the built lib directory.

KieronWiltshire commented 8 years ago

My apologies.