Friend Management Feature Implementation | HacktoberFest 2023

[NayakPenguin]

Hey there! This issue is tailor-made for newcomers who are just getting started with their contributions and have some development skills under their belt. We're here to welcome and support you on your journey! 🚀

We're kicking off this issue to enhance our user experience by adding some exciting friend management features. With this update, users will be able to effortlessly see their friends' performance in a contest.

Tasks :

0. The file you need to work upon is client > src > Screen > ContestAnalysis.js
1. Create a form with fields for the friend's username and picture URL.
2. Trigger this form when the user clicks the "add friend" button.
3. Store the entered data in local storage.
4. Utilize the country-rank-data retrieved to determine the friends's rank.
5. Since the API does not provide the number of problems solved, use a dummy value for it or just write N/A.
6. Make the cross button functional to allow users to remove a friend from local storage.

How to run the repo locally :

Check #104

Important :

1. Please don't change any file other than what is mentioned - if you want please mention it below.

How to get your PR accepted :

1. Consider giving our project a star as it helps enhance the project's credibility.
2. Write the PR title as - # 107 Issue Resolved | {something you want to mention}
3. Write a good PR comment with a screen-shot of the work
4. Make sure to generate the PR to the main branch of this repository.

Express your interest in the open-conversion section below to request this issue as an assignee! Enjoy your coding journey! :) 🚀

[jatingodnani]

interested

[NayakPenguin]

Great @jatingodnani let me assign this issue to you.

[jatingodnani]

i request you to pls assign one issue to one person only.

[NayakPenguin]

Okay sure, it would be assigned to you only for the next 24 hours :) Happy coding 🚀

[NayakPenguin]

@jatingodnani If you are having any issues with running the repo locally, then ask @Mohit030802 (Repo Maintainer) he will solve it. You can also ask him to get on a gmeet to solve it.

[jatingodnani]

solved ! i have a ques ,the table which is showing in above screenshot is not showing in actual ui

[NayakPenguin]

@jatingodnani Click on the search btn, then you go inside another page i.e., http://localhost:4000/contest-analysis/weekly-contest-361

[jatingodnani]

is their any gc for doubt

[NayakPenguin]

Nope sorry :( since it is a small repo I have not created one yet! You can ask your doubts directly on this issue, so others can also have a track of the progress :)

[jatingodnani]

if we take name(leetcodename) and url from form how we fetch the ranking ?is there any api

[NayakPenguin]

Yes! there is an API which is getting called https://nayak-leetcode-api.vercel.app/?weekly_contest=${contestName} which has all the data.

Check your mail

[jatingodnani]

should i make modal type form if we click form will be open

[NayakPenguin]

Yes you can do that, a small modal would be good

I am open to new ideas, you can implement whatever you think makes the feature look better!

[jatingodnani]

why you are not using tailwind

[NayakPenguin]

The most honest answer is - The project began a year and a half ago, and during that period, I didn't feel very confident in my knowledge of tailwind CSS. Maybe in v3.0+ I will start implementing that.

[jatingodnani]

To be honest, we should implement code-splitting to make it easier for beginners to read the code

[jatingodnani]

can i make new folder which contain components like modal,etc

[NayakPenguin]

Yeah sure, go ahead!

[jatingodnani]

Hlo,should i take country name in form to filter easily or should i filter from all countries data?

[NayakPenguin]

How will it ease the search?

I would suggest not taking the country name because the user might not know the country of his friend, and even if he knows his friend can change his country again and again and we wouldn't have a track.

So I think just search in the list and find the username of the friend corresponding to the country name "All Countries" and give that global rank.

If I miss-understood your query then do let me know

[jatingodnani]

@Nayaker my issue is almost complete,i will raise the pr in evening

[NayakPenguin]

Amazing man 🔥

[NayakPenguin]

@jatingodnani any update? I think you texted something, I have missed it :(

[jatingodnani]

@Nayaker review my pr

[NayakPenguin]

Amazing work @jatingodnani issue solved with PR : #112

[NayakPenguin]

@jatingodnani in your PR #112 : I think, you have saved the user's friend's usernames and their ranks on the user's computer right? Well, that caused a big problem because it kept the same ranks for different contests. So, my idea is to only save your friend's usernames, and when you want to see their ranks for a different contest, we can search for them then.

[jatingodnani]

Yes,this is a prblm. @Nayaker add some more issue