Global CSS file : Allcss is hampering other files | HacktoberFest 2023

[NayakPenguin]

I've noticed that the Allcss file is well-made, but it may pose some issues because, throughout the project, we have refrained from using global CSS variables. The global CSS file is only needed for the contest analysis page, so it would be more appropriate to confine the CSS changes to that specific file instead of making them global.

Issue : example it has issues in client > src > Screens > showdownServer.js

Task :

1. make client > src > Allcss local to client > src > Screens > contestAnalysis.js

How to run the repo locally :

Check #104

Important :

1. Please don't change any file other than what is mentioned - if you want please mention it below.

How to get your PR accepted :

1. Consider giving our project a star as it helps enhance the project's credibility.
2. Write the PR title as - # 110 Issue Resolved | {something you want to mention}
3. Write a good PR comment with a screen-shot of the work
4. Make sure to generate the PR to the main branch of this repository.

Express your interest in the open-conversion section below to request this issue as an assignee! Enjoy your coding journey! :) 🚀

[jatingodnani]

Not understand properly

[Arun-Raghav-S]

Hey, could you assign this to me? I am interested to work on this

[NayakPenguin]

Not understand properly

In both the showdownServer.js styled component and the AllCSS model.css, there is a 'btn' class div. However, the desired property is being unintentionally modified in showdownServer.js.

[NayakPenguin]

Hey, could you assign this to me? I am interested to work on this

@Arun-Raghav-S Amazing! I am assigning this issue to you, try to resolve it! It would be better if you could discuss what you are planning to do.

[jatingodnani]

So i can change the classname of one.itwould resolve issue

[NayakPenguin]

Yeah that would be the easiest approach! But since all other files are having the CSS in the same file, it is a bit off to have CSS in different folder for this one.

[Arun-Raghav-S]

Isn't it better to change the className of the modal jsx file to modal-button and the body to modal-body ? Since modal is a reusable component and it may create further issues in the future

[NayakPenguin]

Isn't it better to change the className of the modal jsx file to modal-button and the body to modal-body ? Since modal is a reusable component and it may create further issues in the future

Yes, I agree with your observation. I believe renaming the className of the modal JSX file to 'modal-button' and the body to 'modal-body' would be a wise choice. Given that the modal is a reusable component.

[Arun-Raghav-S]

@Nayaker Please review my PR #116

[NayakPenguin]

@Arun-Raghav-S Check the review on PR!

[jatingodnani]

@Nayaker i resolve the issue,should i raise pr

[NayakPenguin]

You already resolved?

[jatingodnani]

Yup

[NayakPenguin]

Generate PR!

[jatingodnani]

@Nayaker check pr

[NayakPenguin]

Amazing work both @Arun-Raghav-S and @jatingodnani