Closed jinitsuga closed 1 year ago
Just read the whole code, very nice and clean way of writing code @jinitsuga. Amazing man, I have also added your github link on the landing page.
Also thanks for telling me about the UI crash error message, I just resolved it.
I have changed the file structure you did a bit, for a better future understanding of the code like moving the CompetitionItem.js from Screen to Components.
Right now I don't have any issue in mind, but if there is some issue or enhancement that you think exists you can add it to the issues section and work on it.
Filtering by tags working correctly
I took the liberty of moving the 'Competition list items' into its own component (
CompetitionItem.js
) , both to reduce the amount of JSX and to make the JSX structure and code a bit easier to read.Also moved the "filters" (the div buttons that the user clicks) to a simple separate file and imported them as an array, so they can be rendered by simply mapping through it, making it much easier to add logic without repeating code, going from a long JSX tree to simply
<Filters>{filters}</Filters>
.Probably forgot to do cleanup of a couple of functions (returnHours and returnMins) that I moved to the competition list-item component.
-Added myself to contributors
Feel free to point out if you want me to make any modifications.
Unrelated to my changes -->
Ever since the first save and update that I did, I kept getting an error and UI crash, which would get fixed by refreshing the page, but would happen consistently on every save (check img for error message). No idea what's causing this, but leaving the warning here just in case.
Gif of filter by tag: