Algomint / Algorand-MultiSig

Algorand-MultiSig is an open source repo that allows Algorand devs to easily spin up an application that enables multi-sig signing.
4 stars 6 forks source link

UI fixes #10

Open Amiable-Syed opened 2 years ago

Amiable-Syed commented 2 years ago

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Using Chrome developers tool I tested all the responsiveness and checked the UI on Edge, Firefox, and Chrome

Checklist:

Amiable-Syed commented 2 years ago

Description As a UI Frontend developer, I found that the UI can be designed more appealing and responsive so that all the devices could support the portal. So I did UI changes and non of my UI change breaks anything that was done earlier.

Fixes # (issue)

I tested using Chrome developers tool for all the responsiveness and checked the UI on Edge, Firefox, and Chrome

Checklist: [x] I have performed a self-review of my code [x] I have commented my code, particularly in hard-to-understand areas [x] My changes generate no new warnings [x] New and existing unit tests pass locally with my changes

owanhunte commented 2 years ago

Hi @Amiable-Syed this repo is meant to be used as a base repo containing only the original code created by the Algomint devs. The intention is for anyone working on this bounty to fork this repo and commit all submission work to the fork, which is what we will then judge. Unfortunately this means that we won't be accepting/merging PRs coming from forks into this repo since we would not want one hackathon dev's work to end up in another hackathon dev's fork.

So ensure that all your work is committed to your fork and happy hacking!

Amiable-Syed commented 2 years ago

Dear @owanhunte , I didn't create the PR . When you mark your fork repository as done in hackathon submission it automatically creates a PR on the main repository for you guys to review.

owanhunte commented 2 years ago

@Amiable-Syed ah ok I misunderstood, and I see what you mean now. My apologies. We will review your fork.

Amiable-Syed commented 2 years ago

Thank you @owanhunte I really appreciate that