AlgorithMan-de / wyoos

Source codes for the "Write your own Operating System" video-series on YouTube
http://wyoos.org
GNU General Public License v3.0
719 stars 222 forks source link

Fixed error in ata.cpp #5

Open rgwohlbold opened 7 years ago

rgwohlbold commented 7 years ago

Writing two times to the Low port instead of writing to the low and the high port

Jachdich commented 4 years ago

Oh I didn't see this, I just submitted an issue for the same thing. I'll link this.

rgwohlbold commented 4 years ago

Hasn't been merged in a while though :(

Jachdich commented 4 years ago

Yeah, seems this is pretty dead. And I can't get the (modified) PIO driver to work even after fixing it. Are there any pitfalls you know of that I could be falling into?

rgwohlbold commented 4 years ago

Not really... I haven't had any issues with the code except for this problem

Jachdich commented 4 years ago

it's probably either my port_byte_in/out function or some off-by-one error, or maybe my qemu config.