search

AlgorithmCrackers / Interview-Questions

List of all the Interview questions practiced from online resources and books
246 stars 127 forks source link

Typo #16

Closed santhoshvai closed 9 years ago

santhoshvai commented 9 years ago

In 44ded4ca95babf931e8addedab9b387150a9a9c6, minor typo for permutation.

P.S: Also, do document the code well. Your recent commits have been very good but they lack in documentation. When someone else to looks at your code, it takes a while to understand.

prakashn27 commented 9 years ago

okay dude. Can you specify the typo line number. I am still not able to find it. @santhoshvai

santhoshvai commented 9 years ago

@prakashn27 the folder name

prakashn27 commented 9 years ago

@santhoshvai 8ebd0af41a7bfd3004eb6255157173122a4541b0 check this one. Let me know if it is still unclear PS added a new method

santhoshvai commented 9 years ago

Clear now :)

Bug is still there. String/Permutaion/Solution.py

Edit: You have fixed this with another commit

santhoshvai commented 9 years ago

Also something is wrong with Interview-Questions/Trees/ConnectedComponants/, I think you have pushed a incomplete answer

prakashn27 commented 9 years ago

deleted the folder will add correct code before pushing