AlgusDark / bloomer

A set of React components for Bulma CSS Framework
http://bloomer.js.org
MIT License
675 stars 65 forks source link

flow type definitions? #70

Open techieshark opened 6 years ago

techieshark commented 6 years ago

I'm working on a project using Flow, and was trying (unsuccessfully) to generate flow type definitions from the typescript type definitions, using flowgen.

$ cd node_modules/bloomer/lib && flowgen index.d.ts 
Parsing index
Missing node parse ExportDeclaration
Missing node parse ExportDeclaration
Missing node parse ExportDeclaration
Missing node parse ExportDeclaration
Missing node parse ExportDeclaration
Missing node parse ExportDeclaration
... 

I'm curious if you've considered providing flow type definitions, perhaps in the code or through the flow-typed project?

AlgusDark commented 6 years ago

Sorry for my late answer @techieshark.

Actually, I haven't done anything with Flow, so no plans on flow type definitions for the moment. If you have time, it would be really great if you can make those types :)

I'm going to do some research but right now flow is going to be a nice to have feature.

techieshark commented 6 years ago

Thanks @AlgusDark

I've posted an issue with the errors I saw from flowgen, here: https://github.com/joarwilk/flowgen/issues/21

I'm hoping that any advice I might hear back from that issue could be helpful in figuring out how to get an automated process set up to generate flow types from the typescript types you already have.

AlgusDark commented 6 years ago

Thanks, I'll keep an eye on this.

techieshark commented 5 years ago

FYI, this has been fixed in flowgen: https://github.com/joarwilk/flowgen/issues/21#issuecomment-461681306