search

Alhadis / language-grammars

Syntax highlighting for ABNF/BNF/EBNF, Yacc, and other language-related languages.
https://atom.io/packages/language-grammars
ISC License
19 stars 5 forks source link

Grammars clashing with Linguist #1

Closed lildude closed 5 years ago

lildude commented 5 years ago

Woohoo!!! First issue!! 🎉 😁

I'm in the process of preparing for Linguist 7.6.0 and I've just updated all the grammars and this repo, used by several grammars in Linguist, has been flagged by the grammar compiler:

The easy solution is to not bump the SHA for this submodule, but the two grammars at the top may be better than what we're already using in Linguist so maybe a few switcheroo PRs are needed for Linguist?

Alhadis commented 5 years ago

Ah yeah, I was going to include those as well when submitting the PR, but I noticed they weren't perfect, so I held off until I was sure they were. 😁

But, uh, that was actually going to be the plan... so most definitely. 😉

Alhadis commented 5 years ago

BTW, the scopes for the unused *BNF grammars weren't added to grammars.yml, so... how on Earth is Linguist still picking them up? 😕

Alhadis commented 5 years ago

Never mind. It's actually fortuitous this occurred, because I never noticed how badly our ABNF grammar rendered certain files... :|

I'm installing our Docker image on a Ubuntu machine, and will give the compiler a whirl in a minute. Will be able to use this to test grammars locally and ensure stuff like this never happens again. 😅

Alhadis commented 5 years ago

Closing this since the original issue was resolved in github/linguist#4617, but let me know if you're still experiencing troubles. 👍