search

Alhadis / language-regexp

For those who're serious about writing regular expressions.
https://atom.io/packages/language-regexp
ISC License
6 stars 2 forks source link

Add a sample text file #3

Closed waldyrious closed 4 years ago

waldyrious commented 4 years ago

As discussed in #2. This allows previewing the syntax hightlighting of regex on GitHub, since this is the library being used for highlighting regex fenced code blocks.

I'm wondering, is there a reason the image is in a separate branch? Could it be moved to master? Or should this text file also be moved to that branch?

Alhadis commented 4 years ago

I'm wondering, is there a reason the image is in a separate branch?

Yeah, that was to keep Atom from downloading the image with the rest of the package's files when installing it. The image had to be hosted on a whitelisted domain in order to appear on atom.io (which I've just noticed has stopped displaying the image anyway…), so I couldn't just upload the screenshot to Imgur or what-have-you.

waldyrious commented 4 years ago

that was to keep Atom from downloading the image with the rest of the package's files when installing it.

So do we also want to add the sample.regexp file to the separate branch as well? Or is it ok to have it be downloaded with the rest of the code?

Alhadis commented 4 years ago

Nope, just leave it. 👍

Alhadis commented 4 years ago

Done, thanks for your patience!

waldyrious commented 4 years ago

thanks for your patience!

On the contrary, thank you for the detailed explanations along the way :) I'm glad these conversations are now recorded for posterity, should others have similar doubts. Cheers!