search

Ali-Adnan / codecademy-jamming

0 stars 0 forks source link

Summary - Meets Expectations #5

Open jlag34 opened 6 years ago

jlag34 commented 6 years ago

Overall, good job with your project. You were able to conquer Spotify.js which is a huge success. You also included all of your methods and put them all in the right components. The overall functionality of the app works.

I really think investing some time into a prettifier will go a long way for you. Some text editors also let you format your page by highlighting all of the code then selection an option, “format code”. Also be sure to make a copy of your state if you want to work on it outside of `setState. Keep this is mind and keep up the good work.

Ali-Adnan commented 6 years ago

Thank you @jlag34! I just revisited my code and I do find it odd how it was formatted. I did some investigating and the prettifier I installed to Atom had some weird default settings which was causing it to format the code weird. I opened the js files in Dreamweaver and the built-in code cleaner fixed all of the bad indentation and line breaks. Thank you for your feedback on setState as well.