search

AliBayat / Laravel-Categorizable

Implementing Categories system for Laravel's Eloquent models.
MIT License
60 stars 10 forks source link

Not compatible to Laravel v8.17.0 #3

Closed Majid-Kamali closed 3 years ago

Majid-Kamali commented 3 years ago

Hi there, I see bug on laravel-nestedset and fixed but in this package because use version "kalnoy/nestedset": "^5.0", has problem Yet How can I fixed

This is bug

the current version of nestedset is not compatible to Laravel v8.17.0, I get this error message:

[2020-12-01 16:38:34] production.ERROR: Declaration of Kalnoy\Nestedset\BaseRelation::getRelationCountHash() should be compatible with Illuminate\Database\Eloquent\Relations\Relation::getRelationCountHash($incrementJoinCount = true) {"userId":1,"exception":"[object] (ErrorException(code: 0): Declaration of Kalnoy\\Nestedset\\BaseRelation::getRelationCountHash() should be compatible with Illuminate\\Database\\Eloquent\\Relations\\Relation::getRelationCountHash($incrementJoinCount = true) at /home/my-user/my-site/vendor/kalnoy/nestedset/src/BaseRelation.php:133)

issues fixed this problem

AliBayat commented 3 years ago

Hi there, I see bug on laravel-nestedset and fixed but in this package because use version "kalnoy/nestedset": "^5.0", has problem Yet How can I fixed

This is bug

the current version of nestedset is not compatible to Laravel v8.17.0, I get this error message:

[2020-12-01 16:38:34] production.ERROR: Declaration of Kalnoy\Nestedset\BaseRelation::getRelationCountHash() should be compatible with Illuminate\Database\Eloquent\Relations\Relation::getRelationCountHash($incrementJoinCount = true) {"userId":1,"exception":"[object] (ErrorException(code: 0): Declaration of Kalnoy\\Nestedset\\BaseRelation::getRelationCountHash() should be compatible with Illuminate\\Database\\Eloquent\\Relations\\Relation::getRelationCountHash($incrementJoinCount = true) at /home/my-user/my-site/vendor/kalnoy/nestedset/src/BaseRelation.php:133)

issues fixed this problem

the issue has been resolved by upgrading a dependency thanks for reporting