search

AliBazzi / IdentityServer4.Contrib.RedisStore

A persistence layer using Redis DB for operational data and for caching capability for Identity Server 4
https://www.nuget.org/packages/IdentityServer4.Contrib.RedisStore
MIT License
137 stars 48 forks source link

V 3.* fails with IdentityServer4 V4 #37

Closed jhancock4d closed 4 years ago

jhancock4d commented 4 years ago

The new version is out and this causes it all to fail...

AliBazzi commented 4 years ago

I will look into what's new in v4 of IdServ and update it if it's smooth update, but from your comments it doesn't look like it's straightforward.

rangvald86 commented 4 years ago

Hi, was updating to IdentityServer4 v4.0.0 and IdentityServer4.Contrib.RedisStore 3.1.1 today. I getting this error:

An error occurred while starting the application. TypeLoadException: Method 'GetAllAsync' in type 'IdentityServer4.Contrib.RedisStore.Stores.PersistedGrantStore' from assembly 'IdentityServer4.Contrib.RedisStore, Version=3.1.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation. Microsoft.Extensions.DependencyInjection.IdentityServerRedisBuilderExtensions.AddOperationalStore(IIdentityServerBuilder builder, Action optionsBuilder)

TypeLoadException: Method 'GetAllAsync' in type 'IdentityServer4.Contrib.RedisStore.Stores.PersistedGrantStore' from assembly 'IdentityServer4.Contrib.RedisStore, Version=3.1.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.

Do not know if its of any help or if its even related. Would just be nice to get a solution to it :)

AliBazzi commented 4 years ago

V4 introduced a breaking change on the IPersistedGrantStore, and I've looked quickly at it (didn't have the time to look at it fully) and I'm afraid those changes to V4 will leave RedisOperationalStore unusable.

I will update here once I confirm my findings.

rajeshaz09 commented 4 years ago

@AliBazzi , @jhancock4d I don't think we can use redis as operational store going forward. V4 introduced PersistedGrantFilter. This will be used to query data like SQL where clause. Check InMemoryPersistedGrantStore for reference.

AliBazzi commented 4 years ago

I've released an RC for the library that include modified implementation for the V4.

39 Please give it a shot and help in testing.

AliBazzi commented 4 years ago

changes merged, and v4 released.