Open zgoniaiko opened 9 years ago
@AliHichem it looks like connection issue. can you please re-run build.
@AliHichem any chance to merge this pull?
@zgoniaiko the idea of search is to have targeted search that's why the global search is disabled, if we show the global search aside to the target search that will bring confusions and the end user (non-developer user) won't know which search input to use. I like to idea to bring the global search back BUT only in a way where we can toggle it with the input search something like :
setSearch(true, false) => input search
setSearch(true, true) => global search
@AliHichem we can configure global search now (disabled by default).
@zgoniaiko by global search I mean a single input that will make a search on all the fields, the targeted search is the current per field search feature. In your work they work at the "same" time which is double search that is likely to be non-sense, plus the global input search is displayed at the same time with the per-field search which is still non-sense to me.
If we want to add a global search input it has to be switchable with the per-field search and manageable by a config variable (in the search method configurator ) like explained in my last reply.
@AliHichem issue with search input should be fixed in 8291c27
@AliHichem any chance to merge this PR?
Add filter by multiple searchable columns