AliHichem / AliDatatableBundle

Symfony2 Ajax Datagrid Bundle for doctrine2 entities
MIT License
112 stars 72 forks source link

Add filter by multiple searchable columns #146

Open zgoniaiko opened 9 years ago

zgoniaiko commented 9 years ago

Add filter by multiple searchable columns

zgoniaiko commented 9 years ago

@AliHichem it looks like connection issue. can you please re-run build.

zgoniaiko commented 9 years ago

@AliHichem any chance to merge this pull?

AliHichem commented 9 years ago

@zgoniaiko the idea of search is to have targeted search that's why the global search is disabled, if we show the global search aside to the target search that will bring confusions and the end user (non-developer user) won't know which search input to use. I like to idea to bring the global search back BUT only in a way where we can toggle it with the input search something like :

 setSearch(true, false)  => input search
 setSearch(true, true)   => global search
zgoniaiko commented 9 years ago

@AliHichem we can configure global search now (disabled by default).

AliHichem commented 9 years ago

@zgoniaiko by global search I mean a single input that will make a search on all the fields, the targeted search is the current per field search feature. In your work they work at the "same" time which is double search that is likely to be non-sense, plus the global input search is displayed at the same time with the per-field search which is still non-sense to me.

If we want to add a global search input it has to be switchable with the per-field search and manageable by a config variable (in the search method configurator ) like explained in my last reply.

zgoniaiko commented 9 years ago

@AliHichem issue with search input should be fixed in 8291c27

zgoniaiko commented 8 years ago

@AliHichem any chance to merge this PR?