search

AliOsm / chromable

Ruby on Rails integration for ChromaDB
https://github.com/AliOsm/chromable
MIT License
5 stars 0 forks source link

Cast id to string #4

Closed bendangelo closed 9 months ago

bendangelo commented 9 months ago

https://github.com/AliOsm/chromable/blob/main/lib/chromable.rb#L106C16-L106C16

Chroma wants it cast to a string. I'm not sure how you got this working but I had to cast it.

AliOsm commented 9 months ago

I think the reason that I'm using UUID for the model I'm indexing. I will release a fix once I setup my new laptop.

AliOsm commented 9 months ago

Should be fixed in 0.3.3.

bendangelo commented 9 months ago

This also has to be done for chroma_embeddings and chroma_neighbors. Just search for id.

AliOsm commented 9 months ago

You are right, sorry for that 😅 I did the change quickly. Will handle this later today.

bendangelo commented 9 months ago

It would be a good idea to setup a test suite to spot these issues.

AliOsm commented 8 months ago

I will try to do it, this is my first time to setup a gem like this 😅

Would you be able to review them if I make PRs?

bendangelo commented 8 months ago

Yeah sure

AliOsm commented 8 months ago

@bendangelo it should be fixed now in 0.3.4, I hope so :3

bendangelo commented 8 months ago

ok