Memory issue, registering classes.

[njall1]

Registering classes have memory issue:

import Dip

let rootAssembly = DependencyContainer { (container) in
    unowned let container = container

    container.register(.weakSingleton, factory: RootPresenter.init)
        .implements(AnyObject.self,
                    RootModuleInput.self,
                    AppDelegateOutput.self,
                    RootInteractorOutput.self)
        .resolvingProperties { container, presenter in
            presenter.delegate = UIApplication.shared.delegate as! AppDelegate
            presenter.router = try! container.resolve()
            presenter.interactor = try! container.resolve()
            presenter.deeplinkHandler = try! container.resolve()
            presenter.shortcutHandler = try! container.resolve()
    }
...

or

import Dip

let rootAssembly = DependencyContainer { (container) in
    unowned let container = container

    container.register(.weakSingleton, type: RootPresenter.self, factory: RootPresenter.init)
        .implements(AnyObject.self,
                    RootModuleInput.self,
                    AppDelegateOutput.self,
                    RootInteractorOutput.self)
        .resolvingProperties { container, presenter in
            presenter.delegate = UIApplication.shared.delegate as! AppDelegate
            presenter.router = try! container.resolve()
            presenter.interactor = try! container.resolve()
            presenter.deeplinkHandler = try! container.resolve()
            presenter.shortcutHandler = try! container.resolve()
    }
...

or

import Dip

let rootAssembly = DependencyContainer { (container) in
    unowned let container = container

    container.register(.weakSingleton) { RootPresenter() }
        .implements(AnyObject.self,
                    RootModuleInput.self,
                    AppDelegateOutput.self,
                    RootInteractorOutput.self)
        .resolvingProperties { container, presenter in
            presenter.delegate = UIApplication.shared.delegate as! AppDelegate
            presenter.router = try! container.resolve()
            presenter.interactor = try! container.resolve()
            presenter.deeplinkHandler = try! container.resolve()
            presenter.shortcutHandler = try! container.resolve()
    }

I've fixed issue by this way:

import Dip

let rootAssembly = DependencyContainer { (container) in
    unowned let container = container

    container.register(.weakSingleton, type: RootModuleInput.self, factory: RootPresenter.init)
        .implements(AnyObject.self,
                    AppDelegateOutput.self,
                    RootInteractorOutput.self)
        .resolvingProperties { container, presenter in
            presenter.delegate = UIApplication.shared.delegate as! AppDelegate
            presenter.router = try! container.resolve()
            presenter.interactor = try! container.resolve()
            presenter.deeplinkHandler = try! container.resolve()
            presenter.shortcutHandler = try! container.resolve()
    }
...

or

    container.register(.weakSingleton) { RootPresenter() as RootModuleInput }
        .implements(AnyObject.self,
                    AppDelegateOutput.self,
                    RootInteractorOutput.self)
        .resolvingProperties { container, presenter in
            presenter.delegate = UIApplication.shared.delegate as! AppDelegate
            presenter.router = try! container.resolve()
            presenter.interactor = try! container.resolve()
            presenter.deeplinkHandler = try! container.resolve()
            presenter.shortcutHandler = try! container.resolve()
    }
...

Also issue actual for scopes : shared, singleton, eagerSingleton, weakSingleton.

Please provide any solution, because for me very important registering classes not protocols.

[sc0rch]

Move rootAssembly to Application delegate class. It will fix the most of problems.

[njall1]

I checked this way and it has not helped.

import Dip

class AppDelegate: UIResponder, UIApplicationDelegate, AppDelegateInput {

    var window: UIWindow?
    var serviceLocator: ServiceLocator?

    var output: AppDelegateOutput?
    var moduleInput: RootModuleInput?

//    let container: DependencyContainer = rootAssembly

    let container = DependencyContainer { (container) in
        unowned let container = container

        container.register(.weakSingleton) { RootPresenter() }
            .implements(AnyObject.self,
                        RootModuleInput.self,
                        AppDelegateOutput.self,
                        RootInteractorOutput.self)
            .resolvingProperties { container, presenter in
                presenter.delegate = UIApplication.shared.delegate as! AppDelegate
                presenter.router = try! container.resolve()
                presenter.interactor = try! container.resolve()
                presenter.deeplinkHandler = try! container.resolve()
                presenter.shortcutHandler = try! container.resolve()
        }
...

[ilyapuchka]

Can you please state the problem more clear? What is expected, what is actual behaviour?

[njall1]

Expected: If you register a class with the scope: weakSingleton, there must be one instance of this class in memory.

Actual behaviour: I've registered class with scope: weakSingleton

let container = DependencyContainer { (container) in
    unowned let container = container

    container.register(.weakSingleton) { RootPresenter() }
        .implements(AnyObject.self,
                    RootModuleInput.self,
                    AppDelegateOutput.self,
                    RootInteractorOutput.self)
        .resolvingProperties { container, presenter in
            presenter.delegate = UIApplication.shared.delegate as! AppDelegate
            presenter.router = try! container.resolve()
            presenter.interactor = try! container.resolve()
            presenter.deeplinkHandler = try! container.resolve()
            presenter.shortcutHandler = try! container.resolve()
    }

...

But in memory app has 5 instances of this class.

Please provide any solution!

[ilyapuchka]

@njall1 unfortunately I can not understand what the issue can be from your code snippets. If you can submit a failing test this will really help.