search

AliSoftware / Dip

Simple Swift Dependency container. Use protocols to resolve your dependencies and avoid singletons / sharedInstances!
MIT License
978 stars 75 forks source link

Swift 4 #174

Closed danielsaidi closed 6 years ago

danielsaidi commented 7 years ago

Bug fixes for #172 and #173, as described here: https://github.com/AliSoftware/Dip/issues/173

danielsaidi commented 7 years ago

For the tests to work, Travis must run in Xcode 9 mode

leandromperez commented 7 years ago

Hey there! @ilyapuchka are you planning on releasing a new version that supports Swift 4?

ilyapuchka commented 7 years ago

yes, when GM will land

ilyapuchka commented 6 years ago

@danielsaidi I don't see any test failures or compiler errors on Xcode 9 GM, so I guess this change is not needed.

ilyapuchka commented 6 years ago

Ah, it was building with Swift 3.2 by default =(

ilyapuchka commented 6 years ago

@danielsaidi it still fails to compile on TypeForwardingTests.swift:156 and tests are failing in runtime.

danielsaidi commented 6 years ago

Hmmm...I use it in a project in Xcode 9b6 and it builds just fine and works great. I'm away for a couple of days, but I'll have a look at it once I'm back.

Skickat från min iPhone

16 sep. 2017 kl. 18:30 skrev Ilya Puchka notifications@github.com:

@danielsaidi it still fails to compile on TypeForwardingTests.swift:156 and tests are failing in runtime.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

danielsaidi commented 6 years ago

Hahaha I answered by replying from Gmail and it appended all that crap to the end. Can't edit it from my phone. Oh well 🙃

ilyapuchka commented 6 years ago

@danielsaidi thanks for your work! I used it in the #176

ilyapuchka commented 6 years ago

As soon as travis is back to normal I'll merge it and do a release