Closed abesmon closed 5 years ago
Just to make it clear - in our main application we not working directly with setValue
, we set it through Storyboards and result is the same
can you please submit pr with test that demonstrates the issue?
sure, but i cant understand how to do it properly, because my test case use Dip-UI but Demo application not using it
you should do that in Dip-UI repo then
ok. Should i close issue here?
leave it and just refer to it in the pr
Done. Hope somebody can figure out what wrong happens =\
strange thing, that https://github.com/trimmurrti/Dip/commit/9e7bd51bcd86363638c29a777934e2188f021543 works well
@abesmon I'm running your branch: https://github.com/abesmon/dip-ui/tree/feature/several-containers-autoinject-fail
I can't get your test to pass even after @ilyapuchka reverted the #171 and Dip is upgraded to 6.1
It fails in all scenarios
The test appears to fail because at no point does BarSecVC
ever implement StoryboardInstantiatable
.
When I add this to the test:
class BarSecVC: BarOneVC,StoryboardInstantiatable {}
A) It passes with all of the Parent Child
implementation (#171)
b) It passes with Dip v6.1
@abesmon Would you please be able to produce a test that was
a) Failing for 2cc5310d4bc6c1f42d79ff179c21da489988a0f3 (just prior to the (#171) revert
b) passes v6.1
? (revert #171)
@ilyapuchka Still looking for a failing unit test. As stated above, I could not find an test that failed before and passed afterword.
Code to reproduce
What was expected:
fooSecVC.nest.value
andbarSecVC.nest.value
would be not nilWhat happens:
fooSecVC.nest.value
not nil, butbarSecVC.nest.value
is nil. And as seen in our main application, all VC's that are not in first uiContainer, works wrong withInjected<T>()