search

AliSoftware / Dip

Simple Swift Dependency container. Use protocols to resolve your dependencies and avoid singletons / sharedInstances!
MIT License
978 stars 75 forks source link

xcode 10 support #205

Closed ildarsharafutdinov closed 5 years ago

ildarsharafutdinov commented 5 years ago

Since Xcode 10 fails to compile the latest 6.1 there is definitely a need for a new version.

Are there plans to release swift42 branch?

zunjae commented 5 years ago

Also fails for me with the error "Header 'Dip-Swift.h' not found"

Is my only option to downgrade XCode?

Gruppio commented 5 years ago

@zunjae are you using the swift42 branch ?

zunjae commented 5 years ago

No I am not because I have no idea how, though I've manually updated the source code for Dip in order to make it work in my application.

hellbit commented 5 years ago

I have 2 errors. Use swift 4.0

  1. 'ImplicitlyUnwrappedOptional' has been renamed to 'Optional'
  2. Command CompileSwift failed with a nonzero exit code
vinters768 commented 5 years ago

@zunjae pod 'Dip', :git => 'https://github.com/AliSoftware/Dip.git', :branch => 'swift42'

AndrewKochulab commented 5 years ago

Where is the branch swift 42? This library still crashes on the Xcode 10.

vinters768 commented 5 years ago

Where is the branch swift 42? This library still crashes on the Xcode 10.

try using this in your Podfile: pod 'Dip', :git => 'https://github.com/AliSoftware/Dip.git', :branch => 'swift42'

AndrewKochulab commented 5 years ago

Where is the branch swift 42? This library still crashes on the Xcode 10.

try using this in your Podfile: pod 'Dip', :git => 'https://github.com/AliSoftware/Dip.git', :branch => 'swift42'

There is no branch with name swift42 Errors from the terminal: [!] Error installing Dip [!] Failed to download 'Dip'.

vinters768 commented 5 years ago

Where is the branch swift 42? This library still crashes on the Xcode 10.

try using this in your Podfile: pod 'Dip', :git => 'https://github.com/AliSoftware/Dip.git', :branch => 'swift42'

There is no branch with name swift42 Errors from the terminal: [!] Error installing Dip [!] Failed to download 'Dip'.

it looks like @ilyapuchka updated master for Swift 4.2 support, if you're still having issues, try removing and re-adding Dip from the Podfile, or try an empty project.. it works fine for me.

ilyapuchka commented 5 years ago

@AndrewKochulab there was a release for Swift 4.2. Please open another issue if you experience any problems.