Added long press event & fixed memory leak

AliSoftware / OHAttributedLabel

UILabel that supports NSAttributedString

https://github.com/AliSoftware/OHAttributedLabel/wiki

1.51k stars 344 forks source link

Added long press event & fixed memory leak #177

Open JonasGessner opened 10 years ago

AliSoftware commented 10 years ago

Nice addition but two questions:

Why the enabled=NO then enabled=YES here?
Couldn't we mutualize some code about detection of the link under the tapped point between the tapGR and the longPressGR ?

A bit busy so won't have time to review it all until at least next WE anyway, please be patient ;)

JonasGessner commented 10 years ago

The enabled part is unnecessary. It is used to cancel a gesture recognizer but in this case it doesn't need to be cancelled.

About mutualizing code: Some mutualization would be possible but we are really just talking about a few lines of code so I think the code is fine like this.