Migrate samples to Swift 3

AliSoftware / OHHTTPStubs

Stub your network requests easily! Test your apps with fake network data and custom response time, response code and headers!

MIT License

5.04k stars 601 forks source link

Migrate samples to Swift 3 #205

Closed dhardiman closed 8 years ago

dhardiman commented 8 years ago

Carthage seems to find this example project and fall over when the dependencies are checked using Xcode 8 as it’s not specifying the swift version. This appears to fix that. It does seem to build the framework target twice due to the cocoa pods usage for the example, but I don’t think that causes a problem. Perhaps in future the example project could link directly to the project rather than using CocoaPods to solve that, but probably not urgent.

AliSoftware commented 8 years ago

👌 Could you also add an entry in the CHANGELOG to credit yourself for this migration? Thx!

dhardiman commented 8 years ago

Sure, updated. Hope the format is ok above the previous release? Let me know if not and I'll fix.

AliSoftware commented 8 years ago

Travis-CI builds are currently failing due to a bug in the latest version of xcpretty: https://github.com/supermarin/xcpretty/issues/241 — Waiting for the fix.

AliSoftware commented 8 years ago

Merged manually via ca8e9c295b859215b1ab8a9df8e0546a24e768e5

Thanks again!