fix xcode 9 warnings and recommended settings

AliSoftware / OHHTTPStubs

Stub your network requests easily! Test your apps with fake network data and custom response time, response code and headers!

MIT License

5.04k stars 601 forks source link

fix xcode 9 warnings and recommended settings #267

Closed NikSativa closed 5 years ago

NikSativa commented 6 years ago

Checklist

[x] I've checked that all new and existing tests pass
[x] I've updated the documentation if necessary
[x] I've added an entry in the CHANGELOG to credit myself

Description

Motivation and Context

AliSoftware commented 6 years ago

Builds seem to be failing due to SWIFT_VERSION not being set appropriately?

NikSativa commented 6 years ago

did update both projects and all targets/framworks to the latest version of xcode 9.1 and swift version 4.0. all warnings and errors are fixed

AliSoftware commented 6 years ago

Doesn't Xcode 9.1 require Swift 4.0.2 instead of 4.0?

NikSativa commented 6 years ago

no, 4.x required 4.0.2 is the minor update

AliSoftware commented 6 years ago

Yeah but for people using Carthage, which builds the framework based on the settings in the Xcode project before linking it to the integrating product, they'll probably want the framework to be built with the latest Swift ABI & version, so 4.0.2 ?

NikSativa commented 6 years ago

xcode contains only 1 integrated version inside thats why xcode 9.0 will contain 4.0, but xcode 9.1 - 4.0.2 and inside project/target setting the version will be the same 4.0 see screenshot:

AliSoftware commented 6 years ago

:+1: (Full disclosure: I only checked from the github web interface as I was on my phone and not at a computer, sorry)

jeffctown commented 5 years ago

@NikSativa - Hey there! We just released version 7 of OHHTTPStubs which is compatible with Xcode 10 and Swift 4.x, so I am closing this PR out, but I wanted to say thank you for submitting it! We really appreciate the community support!

We actually thanked you directly in the release notes.