update swift demo compatibility with swift 4.2

AliSoftware / OHHTTPStubs

Stub your network requests easily! Test your apps with fake network data and custom response time, response code and headers!

MIT License

5.03k stars 601 forks source link

update swift demo compatibility with swift 4.2 #292

Closed hellensoloviy closed 5 years ago

hellensoloviy commented 5 years ago

Checklist

[x] I've checked that all new and existing tests pass
[x] I've updated the documentation if necessary
[x] I've added an entry in the CHANGELOG to credit myself (I'm not sure if I add it in correct place but I add, fix it if needed please)

Description

Update swift example project to swift 4.2 version and fix compatibility issue;

Motivation and Context

It helps to build and run project on last swift an xcode

no, there is no open issue

build and run the example app. Run all tests also

hellensoloviy commented 5 years ago

Hello! Thanks for the answer on my PR :) I have made some changes based on your comments, so u can look at it if u wanna)

Have a nice evening!

On Oct 27, 2018, at 5:34 PM, AliSoftware notifications@github.com wrote:

Maybe at this point we'd just state "from 2.2 to 4.2"… although I'm not sure that's really true. We might have dropped 2.x support at some point and forgot about updating that part of the README maybe? Would be good to check if we're still compatible with 2.x… or remove that from the sentence altogether as probably nobody uses 2.2 anymore…

hellensoloviy commented 5 years ago

Yes, it's better to add it! Thanks for noticing. I've added it)

On Oct 27, 2018, at 6:33 PM, AliSoftware notifications@github.com wrote:

@AliSoftware commented on this pull request.

In OHHTTPStubs/OHHTTPStubs.xcodeproj/project.pbxproj https://github.com/AliSoftware/OHHTTPStubs/pull/292#discussion_r228716848:

@@ -1735,6 +1746,7 @@ SDKROOT = appletvos; SKIP_INSTALL = YES; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";

SWIFT_VERSION = 4.2; Mmmh I see we actually never added that s.swift_version line to the podspec actually… might be the occasion to do so then

http://blog.cocoapods.org/CocoaPods-1.4.0/#swift-version-dsl http://blog.cocoapods.org/CocoaPods-1.4.0/#swift-version-dsl — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AliSoftware/OHHTTPStubs/pull/292#discussion_r228716848, or mute the thread https://github.com/notifications/unsubscribe-auth/ARU4Dam10SGJleCPnLrwr1hsb3d3gy0Mks5upHy_gaJpZM4X9cep.

jeffctown commented 5 years ago

@hellensoloviy - Hey there! We just released version 7 of OHHTTPStubs which is compatible with Xcode 10 and Swift 4.x, so I am closing this PR out, but I wanted to say thank you for submitting it! We really appreciate the community support!

We actually thanked you directly in the release notes.

hellensoloviy commented 5 years ago

Hi, @jeffctown Thanks for your explanation & mention. I'm glad my PR was of help :)