search

AliSoftware / OHHTTPStubs

Stub your network requests easily! Test your apps with fake network data and custom response time, response code and headers!
MIT License
5.03k stars 601 forks source link

Enables application extension API only #293

Closed lightsprint09 closed 5 years ago

lightsprint09 commented 5 years ago

Checklist

Description

Adds support for using OHHTPStubs in application extension. OHHTPStubs does not use any API which is restricted inside extension, so enabling support is just ticking 3 boxes (iOS, macOS, tvOS).

Motivation and Context

Linking OHHTPStubs to an application extension works find but creates a warning. This change targets a warning free project.

lightsprint09 commented 5 years ago

Thanks for the quick reply. Added a changlog and waiting for your comments now.

marcussc commented 5 years ago

@lightsprint09 @AliSoftware is there anything I can help with to get this merged?

AliSoftware commented 5 years ago

Sorry for not being super responsive, haven't had a lot of time to work on my many OSS lately, and I don't have a Mac at home anymore (keyboard repair in progress) to test this PR unfortunately.

@marcussc You could try to integrate the fork in a project (If you're integrating it using CocoaPods, just use pod 'OHHTTPStubs', :git => 'https://github.com/lightsprint09/OHHTTPStubs', :branch => 'extension-support' in your Podfile), do a clean build, and confirm it solves the problem. If so, I'll probably merge it right away.

marcussc commented 5 years ago

@AliSoftware Just integrated the Fork in inside my Project via Carthage. After a clean build the warning is gone. Looks good for me 👍

AliSoftware commented 5 years ago

Cool, thx 👍

I have a few other PRs left on which I've been late on reviewing and merging, will try to catch up on them all this week so I can release of a new version properly ASAP 😅