search

AliSoftware / OHHTTPStubs

Stub your network requests easily! Test your apps with fake network data and custom response time, response code and headers!
MIT License
5.03k stars 601 forks source link

Disabling troublesome unit test. #301

Closed jeffctown closed 5 years ago

jeffctown commented 5 years ago

Updating Readme with known issue. Changelog.

Checklist

Description

Disabling flaky tests and updating README with the known issue.

Motivation and Context

There has been an issue with redirects for several years that seems to be caused by an Apple bug. This issue has been investigated multiple times, and the path that we want to take forward is to disable the buggy test and update the README with the known issue.

Discussion on this topic has been mostly happening in #230 and #280 .

AliSoftware commented 5 years ago

As commented in #298 maybe we should have kept that test enabled by default when run on Xcode and only disable it on CI (the same way I did with timing tests)?

jeffctown commented 5 years ago

@AliSoftware I think this is a great idea. I can make put up a pull request with that change soon, and it makes way more sense than just disabling it globally.

Would you prefer for me to wait for your approval on any of these pull requests before merging? You're bringing up totally valid concerns on them.

AliSoftware commented 5 years ago

In a dream world 🦄 I'd say if you could let me the day after you opened a PR to have a chance to review it before merging, that could be interesting (at least for the first PRs you take responsibility for) so that I can validate the direction… But given how busy I am with induction into my new job I can't guarantee that I'll be as fast to react or review all your other PRs (tonight was just a light evening, not expecting many ^^) 😓

So given how you seem to have good motivation and you're helping unlocking a situation that I did let stale for too long (And thanks again for that 🙏), sure if there's a PR that can wait a few hours or the day then maybe you could wait so I might take a look before you merge… but in any case if you see I'm not reacting after one day (while @liquidsoul approves the PR on his end), or a change is trivial, feel free to make things go forward without waiting for me — so that we don't continue having that stale situation on OHHTTPStubs that I kept postponing for too long for lack of my own availability. (We could always revert a PR if needs be in case of emergency after all)

jeffctown commented 5 years ago

@AliSoftware - Sounds reasonable to me. 👍 I can continue in this fashion.