Xcode 12 - Warnings related to iOS 8 support (Swift Package Manager)

AliSoftware / OHHTTPStubs

Stub your network requests easily! Test your apps with fake network data and custom response time, response code and headers!

MIT License

5.03k stars 602 forks source link

Xcode 12 - Warnings related to iOS 8 support (Swift Package Manager) #328

Closed spekke closed 3 years ago

spekke commented 3 years ago

New Issue Checklist

[x] I have tried with the latest version of OHHTTPStubs
[x] I have read the README
[x] I have read the Using the right Swift Version of OHHTTPStubs for your project section
[x] I have searched in the existing issues
[x] I have read the OHHTTPStubs wiki to see if there wasn't a detailed page talking about my issue

Environment

version of OHHTTPStubs: 9.0.0
integration method you are using:
- [ ] Cocoapods
- [ ] Carthage
- [ ] submodule
- [x] other (Swift Package Manager)
version of the tool you use: Xcode 12

Issue Description

When building a project that integrates OHTTPStubs via Swift Package Manager - Xcode 12 outputs the following warning message.

Complete output when you encounter the issue (if any)

The iOS Simulator deployment target ‘IPHONEOS_DEPLOYMENT_TARGET’ is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target ‘OHHTTPStubsSwift’ from project ‘OHHTTPStubs’)

ThomWee commented 3 years ago

Would be nice if the project settings can be updated soon. Or is this project no longer maintained? Last change was beginning of this year.

kikeenrique commented 3 years ago

According to Xcode 12 release notes in https://developer.apple.com/documentation/xcode-release-notes/xcode-12-release-notes:

Xcode 12 includes SDKs for iOS 14, iPadOS 14, tvOS 14, watchOS 7, and macOS Catalina 10.15.6. The Xcode 12 release supports on-device debugging for iOS 9 and later, tvOS 9 and later, and watchOS 2 and later. Xcode 12 requires an Intel-based Mac running macOS Catalina 10.15.4 or later.

With this patch, warning is fixed.

---
 Package@swift-5.swift | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Package@swift-5.swift b/Package@swift-5.swift
index c393a22..ce31904 100644
--- a/Package@swift-5.swift
+++ b/Package@swift-5.swift
@@ -4,7 +4,7 @@ import PackageDescription
 let package = Package(
     name: "OHHTTPStubs",
     platforms: [
-        .macOS(.v10_10), .iOS(.v8), .watchOS(.v2), .tvOS(.v9)
+        .macOS(.v10_10), .iOS(.v9), .watchOS(.v2), .tvOS(.v9)
     ],
     products: [
         .library(
--

jeffctown commented 3 years ago

@ThomWee There definitely isn't much activity here these days.

@kikeenrique If you would be nice enough to submit a PR for that, I'd be happy to accept it.

kikeenrique commented 3 years ago

@jeffctown Thanks for your offering. I've already created a PR.

Kaspik commented 3 years ago

@jeffctown Hey! Is there a plan to release this as a tag/release for SPM users so we don't have to point to commit / branch? Thanks.

jeffctown commented 3 years ago

Sure, I can do that @Kaspik . I put up a PR to handle it.