Closed jeffctown closed 3 years ago
@thii - Just want to confirm this is the right spot.
Looks like I can't merge my own PR unless someone other than me with write access approves it. @AliSoftware lil help?
I'm happy to approve; but I have no idea what this PR is about and what this BUILD file is… 😅
It's adds support for Bazel, which is Google's alternative build system. I'm not very familiar with it either, but this is what it is if you're interested.
Ahhh ok. Do we have a CHANGELOG entry for this and a mention in the README or CONTRIBUTING that we're supporting Bazel?
In the original PR (long ago), originally I just intended to add a missing import (so that we wouldn't have to patch it), but ended up adding a BUILD file upon a suggestion. It was somewhat incomplete now that I'm looking at it again. People who use Bazel to build their iOS app often have custom rules and write BUILD files themselves, so I'm not sure if you still want to keep and provide support for it.
Never having found the time myself to dig into Bazel (even though I've always wanted to try) I personally won't provide support myself, but I'm not the only maintainer of this OSS repo anymore so if anyone else is comfortable enough and able to provide support I don't see any reason not to keep it.
I'm just a bit sad that be Bazel didn't choose a more descriptive name for that file like Bazelfile
(to be more aligned with what every other tooling is naming their config files), since anyone not familiar with Bazel won't know what this file is about. I think if possible we should add a comment at the top of this BUILD file to document what it is at least?
Bazel also supports BUILD files named BUILD.bazel
, so we can use that.
Perfect, let's update the name of the file then, and then we can merge this!
Sorry for the back and forth. Upon a second thought, I think we should remove the BUILD file from the repo. The reasoning being:
glob
does not match files in subpackages).Fair enough 👍
Of course I'll wait for tests to pass before merging, but this is otherwise good to go @AliSoftware .
Thanks for taking care of this. Feel free to merge in green.
Description
Moving the BUILD file to it's proper place.