AliSoftware / OHHTTPStubs

Stub your network requests easily! Test your apps with fake network data and custom response time, response code and headers!
MIT License
5.03k stars 602 forks source link

Incorrect example for onStubActivation on Usage Examples page #333

Open kirilstrax opened 3 years ago

kirilstrax commented 3 years ago

New Issue Checklist

Environment

Issue Description

The example on Usage Examples page is shown as follows:

// Swift
OHHTTPStubs.onStubActivation() { request, stub in
  println("\(request.URL!) stubbed by \(stub.name).")
}

Problem 1: Signature of onStubActivation was changed a few versions ago. So it should be:

OHHTTPStubs.onStubActivation() { request, stub, response in

This problem applies to both, Swift and Objective C examples

Problem 2: replace println with print in Swift, as there's no println function in swift.

Problem 3: in Swift, NSURLRequest is bridged as URLRequest, and instead of request.URL!, it uses lower-cased request.url!

Bottom line: example in Swift should look something like this:

// Swift
OHHTTPStubs.onStubActivation() { request, stub, response in
  print("\(request.url!) stubbed by \(stub.name) of size \(response.dataSize).")
}
Complete output when you encounter the issue (if any)

This is documentation update issue, so not applicable.