AliSoftware / OHHTTPStubs

Stub your network requests easily! Test your apps with fake network data and custom response time, response code and headers!
MIT License
5.03k stars 602 forks source link

Updated ios min deployment target to 11 for xcode 14.3 support. #361

Closed adamsousa closed 5 months ago

adamsousa commented 1 year ago

Checklist

Description

Updated iOS deployment target to iOS 11, minimum supported in Xcode 14.3

Motivation and Context

Allows framework to be built using xcode 14.3

kishorepran commented 1 year ago

@adamsousa : there are more places this needs to be updated. i.e. podspec, podfile etc.

MagFer commented 1 year ago

@kishorepran, could you create a PR towards https://github.com/adamsousa/OHHTTPStubs/tree/xcode-14.3 with the CocoaPods files pending to set the min target to iOS 11?

Liquidsoul commented 10 months ago

Thank you all for your work and sorry I could not look into this sooner.

So we're stuck here because I do not have the rights to bypass the required CI step that does not seem to run.

I've gathered all the bumping changes in this branch and I will try to reach @AliSoftware to see if I can get the administrator rights on this. Let's hope that this is resolved soon 🤞

AliSoftware commented 7 months ago

Sorry for the huge delay on this.

see if I can get the administrator rights on this

@Liquidsoul I'd have been happy to give you admin permissions, but it seems GitHub doesn't have an option to give administrator access to a repo if it's a personal repo and not in a Team Organization 😞

there are more places this needs to be updated. i.e. podspec, podfile etc.

@Liquidsoul Can you help make this PR ready for merge, by ensuring that all the necessary parts are updated (especially not just the Xcode project settings like now, but also the .podspec)? Or maybe just open a PR for your branch that already contains everything needed? Once it's ready, I'll come back to admin-merge, to bypass the broken CI.

As for CI being broken, this will need separate work—I'm thinking at migrating away from travis and switch to something like GitHub Actions, but not sure when I'll have the bandwidth tbh.

adamsousa commented 7 months ago

@AliSoftware I updated my PR with podfile and .podspec targeting iOS 11. Also updated the example projects.

kishorepran commented 7 months ago

@AliSoftware : you can give me collaborator access. in that way I can help raise a pr that migrates from CI to GitHub actions. I have done this for many projects. Thanks.

https://docs.github.com/en/issues/planning-and-tracking-with-projects/managing-your-project/managing-access-to-your-projects

Also

  1. I want to close the list of issues and bugs that are not relevant anymore by reaching out to people and asking them to re-open this issue if this still relevant.
  2. Support with xcprivacy.manifest and 3rd party signature management if needed from xcode 15.
kishorepran commented 7 months ago

@AliSoftware I updated my PR with podfile and .podspec targeting iOS 11. Also updated the example projects.

Package.Swift update missing. need to update that as well.

adamsousa commented 7 months ago

@kishorepran Added

kikeenrique commented 6 months ago

I miss a bump in tvOS deployment version as its minimal version is tvOS 11 in Xcode 14.X At least for SPM (check for reference my PR https://github.com/AliSoftware/OHHTTPStubs/pull/352)

arjankowski commented 5 months ago

Hi @AliSoftware @Liquidsoul, is there any chance of merging this PR?