Aliahmad-karimi / My-Portfolio

Showing to the world my abilities inside this Portfolio

0 stars 0 forks source link

Some improve advices to your code #6

Closed MarcoOquendoC closed 2 years ago

MarcoOquendoC commented 2 years ago

Hi @Aliahmad-karimi,

We found some issues you could use to improve your project.

I like the way you arrange all your code, it is neat. I think you can change the indentation to 2 spaces so it get even more readable.
I think you cou add a mockup image in your readme file.
I think you could erase blank spaces in your index.html file.
It could be a good idea to use article tag intead of divs in the card containers.
You can use an "a" tag for the navigation icon in the nav bar.