search

Alibaba-NLP / ACE

[ACL-IJCNLP 2021] Automated Concatenation of Embeddings for Structured Prediction
Other
298 stars 44 forks source link

Incorrect ModelTrainer() arguments in tutorials #10

Closed Aatlantise closed 3 years ago

Aatlantise commented 3 years ago

Hello,

Thank you for your extensive tutorials. They have been very helpful.

I came across a minor error in the tutorial code, however. The first keyword argument while initializing the ModelTrainer object is a teacher model, rather than corpus. So, lines like trainer: ModelTrainer = ModelTrainer(tagger, corpus) in https://github.com/Alibaba-NLP/ACE/blob/main/resources/docs/EXPERIMENTS.md return an attribute error that can be fixed with trainer: ModelTrainer = ModelTrainer(tagger, corpus = corpus)

wangxinyu0922 commented 3 years ago

Hi,

I modified the code of flair a lot, therefore please follow the README.md in the main directory to run our code. The EXPERIMENTS.md is the old guide in flair. I'm sorry for the guide that misleads you. I will delete the EXPERIMENTS.md in the next commit.

Aatlantise commented 3 years ago

Gotcha. Thanks for your clarifications :)