search

AliceO2Group / DelphesO2

Interfacing Delphes with the AliceO2
3 stars 18 forks source link

First ECAL implementation #120

Closed kharlov closed 3 years ago

njacazio commented 3 years ago

Hi @kharlov please trigger me when you need to have this PR reviewed

kharlov commented 3 years ago

Hi @njacazio , I fixed several bugs in ECAL response, please check and merge the new PR.

njacazio commented 3 years ago

Also, there are some conflicts that have to solved before this can be merged

kharlov commented 3 years ago

Hi @njacazio , I solved conflicts, ran clang and opened a new PR. Did I do it correctly?

njacazio commented 3 years ago

Hi Yuri, yes, I will have a look asap

njacazio commented 3 years ago

Hi @kharlov your changes will be merged from here https://github.com/AliceO2Group/DelphesO2/pull/126

kharlov commented 3 years ago

Hi @njacazio , I fixed one more bug in ECAL response: photon hit coordinate was not calculated correctly.

njacazio commented 3 years ago

Hi, @kharlov, perfect, I will include it in the software as soon as you push it in this PR

njacazio commented 3 years ago

Ah, I just saw that you already did, I will import it now

njacazio commented 3 years ago

Closing as already merged in other PR