search

AliekberFFXI / xivcrossbar

FFXIV-style crossbar for FFXI -- Based on Edeon's XIVHotbar
MIT License
11 stars 5 forks source link

Various submenus not working in binding selection #18

Open Kharazidusk opened 1 year ago

Kharazidusk commented 1 year ago

There are various submenus that are supposed to be filled by abilities - such as Ward, Rune Enchantment, Jigs or Steps, that return nothing when clicked. Makes binding stuff like Spectral Jig and Vallation impossible. JAbug

Kharazidusk commented 1 year ago

To recreate, jump on a job that has a menu inside of a menu for a job action, such as Rune Fencer or Dancer and try to bind from the corresponding action - Ward for Rune Fencer, Jig/Steps for Dancer.

Kharazidusk commented 1 year ago

Update: these menus work for some jobs, but not for others. Corsair, for example, has a sub-menu in Phantom Roll which displays all dice just fine. So, some are broken, some aren't. I haven't checked jobs other than Rune Fencer and Dancer as of yet.

Kharazidusk commented 1 year ago

Okay, so I did some looking after I had to switch to /DNC for a fight to see why it wasn't working. This is probably not the solution, but it seems to have worked for a reason that I'm not smart enough to know. When trying to head into these menus to find the specific dance/ward/etc that I need, I'd get the error, "xivcrossbar/action_binder.lua:2105: attempt to index global 'command' (a nil value)"

My first thought was to head to that line in that lua file - there, dances and wards(and maybe other types of skills) seem to be indexed as those specific things, rather than a general command like stuff like stratagems appear to be. I changed the appropriate call(maybe? is that what this is called?) for a "command.name" and "command.id" to be "dance.name" and "dance.id". Worked like a charm. I tested to make sure Healing Waltz worked fine when I put it on my bar, and it did.

Again, this probably isn't the right fix(and if it is, happy to save you some time!), but I figured I'd put it here anyway.

Cheers for your time!