Fixes #30: API_V1_ROOT backslash

deadbits commented 7 years ago

Adds backslash to https://github.com/AlienVault-Labs/OTX-Python-SDK/blob/master/OTXv2.py#L17
Adds minor PEP fixes for over indentation of lines and whitespace after operators in a few spots

deadbits commented 7 years ago

Tests are failing due to missing ALIEN_DEV_SERVER the ci environment, I believe. If this can be added by a maintainer, or as @bsmartt13 said "if you make me a maintainer/collaborator on the github side, I can fix the build fail." :)

If there is something I'm missing here with my related issue and this PR, any input would be great as well.

Relevant excerpts from CI failure:

requests.post(ALIEN_DEV_SERVER + 'otxapi/qatests/setup/', json={"users": [{ "username": username, "password": password, "email": email}]})
requests.exceptions.MissingSchema: Invalid URL 'otxapi/qatests/setup/': No schema supplied. Perhaps you meant http://otxapi/qatests/setup/?

chrisdoman commented 7 years ago

Thanks! I think there are a couple of other issues relating to test failures I need to review too

deadbits commented 7 years ago

Was Issue #30 a non-problem as well? Perhaps it's just my build for some reason, since I haven't seen anyone else mention problems with it, j/w if PR will be merged

chrisdoman commented 7 years ago

Yup it will be if I click the correct button this time :) Merging and will double check in a sec

deadbits commented 7 years ago

Thanks for the quick follow up! :D

AlienVault-OTX / OTX-Python-SDK

Fixes #30: API_V1_ROOT backslash #31