search

Alignak-monitoring / alignak

Monitoring tool, highly flexible and new standard oriented
https://alignak-monitoring.github.io
GNU Affero General Public License v3.0
86 stars 19 forks source link

Give a try to fix #1084 #1085

Closed mohierf closed 5 years ago

mohierf commented 5 years ago

Parameters inheritance - some simplifications and fixes

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@f874249). Click here to learn what that means. The diff coverage is 79.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1085   +/-   ##
==========================================
  Coverage           ?   85.39%           
==========================================
  Files              ?      102           
  Lines              ?    17530           
  Branches           ?        0           
==========================================
  Hits               ?    14969           
  Misses             ?     2561           
  Partials           ?        0
Impacted Files Coverage Δ
alignak/objects/service.py 82.8% <100%> (ø)
alignak/objects/contact.py 88.34% <100%> (ø)
alignak/daemons/arbiterdaemon.py 73.94% <50%> (ø)
alignak/objects/schedulingitem.py 89.94% <61.11%> (ø)
alignak/objects/item.py 91.12% <84%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f874249...ba79ea0. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@6cd7789). Click here to learn what that means. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #1085   +/-   ##
=========================================
  Coverage           ?   75.3%           
=========================================
  Files              ?     102           
  Lines              ?   17528           
  Branches           ?       0           
=========================================
  Hits               ?   13200           
  Misses             ?    4328           
  Partials           ?       0
Impacted Files Coverage Δ
alignak/objects/service.py 81.29% <100%> (ø)
alignak/objects/contact.py 88.34% <100%> (ø)
alignak/daemons/arbiterdaemon.py 44.34% <50%> (ø)
alignak/objects/schedulingitem.py 87.06% <62.5%> (ø)
alignak/objects/item.py 90.99% <84%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6cd7789...5612c87. Read the comment docs.