Alignak-monitoring / alignak

Monitoring tool, highly flexible and new standard oriented
https://alignak-monitoring.github.io
GNU Affero General Public License v3.0
86 stars 19 forks source link

Docker images #1106

Closed palvarezcordoba closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #1106 into docker-images will decrease coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           docker-images    #1106     +/-   ##
================================================
- Coverage          85.23%   85.13%   -0.1%     
================================================
  Files                102      102             
  Lines              17607    17607             
================================================
- Hits               15007    14990     -17     
- Misses              2600     2617     +17
Flag Coverage Δ
#tests 85.13% <ø> (-0.1%) :arrow_down:
#tests_integ 61.35% <ø> (-0.18%) :arrow_down:
Impacted Files Coverage Δ
alignak/satellite.py 81.87% <0%> (-2.56%) :arrow_down:
alignak/scheduler.py 91.69% <0%> (-0.48%) :arrow_down:
alignak/daemon.py 83.52% <0%> (-0.14%) :arrow_down:
alignak/objects/notificationway.py 88.97% <0%> (+0.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c565cf...23ef52c. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #1106 into docker-images will decrease coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           docker-images    #1106     +/-   ##
================================================
- Coverage          85.23%   85.13%   -0.1%     
================================================
  Files                102      102             
  Lines              17607    17607             
================================================
- Hits               15007    14990     -17     
- Misses              2600     2617     +17
Flag Coverage Δ
#tests 85.13% <ø> (-0.1%) :arrow_down:
#tests_integ 61.35% <ø> (-0.18%) :arrow_down:
Impacted Files Coverage Δ
alignak/satellite.py 81.87% <0%> (-2.56%) :arrow_down:
alignak/scheduler.py 91.69% <0%> (-0.48%) :arrow_down:
alignak/daemon.py 83.52% <0%> (-0.14%) :arrow_down:
alignak/objects/notificationway.py 88.97% <0%> (+0.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c565cf...23ef52c. Read the comment docs.

mohierf commented 5 years ago

@palvarezcordoba : what is to be done with this PR? Is is still relevant if we consider #1107 ?

An sorry for the delay... :/

palvarezcordoba commented 5 years ago

@mohierf The most important part is fixing a problem with permissions. If a run docker-compose up Alignak fails because lack of permissions on data dir. But there is some wrong things in this PR. I'll do it better and create another PR soon.

Sorry for the inconvenience and thanks.

mohierf commented 5 years ago

@palvarezcordoba thanks for the explanations. I understood the insterest of your endpoint.sh script +1 I worked on the Docker images tonight and I will submi some modifications probably tomorrow or Friday ... stay tuned 😉