Closed Seb-Solon closed 9 years ago
Enhancement: Refactor list parsing in configuration (empty string should be casted "[]" or "None") (ie: contactgroups parameter)
Concerning this item, imho, any configuration attribute/directive which can contain multiple values, often (if not always ? which would be better..) separated by commas, should always result in a list assigned to that attribute at the object level. Whatever are the actual number of values given for the attribute (0 / 1 / more..) in the/a configuration file. Hardcoded default list values could be used for some attributes, as it is right now but in anyway the type(obj.attribute)
should always be list
; not NoneType
. That would simplify the logic at quite some place in the code where sometimes there are pattern/things like :
if obj.attr is not None: # or shorter: if obj.attr:
for item in obj.attr:
# do something with item
Enhancement : Rework logger, differanciate naglog and shinken log naparuba/shinken#1525 naparuba/shinken#1201
+1
What do you mean by "naglog" ?
What do you mean by "naglog" ?
def naglog_result(level, result, *args):
"""
Function use for old Nag compatibility. We to set format properly for this call only.
Dirty Hack to keep the old format, we should have another logger and
use one for Shinken logs and another for monitoring data
"""
Enhancement: Ensure unicode in all stringProp (@Seb-Solon)
I guess you mean that, for every stringprop, we must result in a unicode string stored in the object attribute, not a byte string ? if yes : +100000