search

AlignmentResearch / KataGoVisualizer

MIT License
3 stars 1 forks source link

Code Review #1

Closed UFO-101 closed 1 year ago

UFO-101 commented 1 year ago

This fake PR has all the code in the repo so it's easier to review and add comments.

TODO:

I recommend reading the README before reviewing the code.

UFO-101 commented 1 year ago

don't really know Streamlit well enough to comment on the structure on the code so all my comments are just a bunch of nits. Overall seems fine

Thanks for the feedback! Nits are useful 😄 I'll get to these when I've finished my current task

UFO-101 commented 1 year ago

Addressed all comments. Changes can be seen in main. Unfortunately this PR for the whole code base is now messed up in Github.