AlignmentResearch / KataGoVisualizer

MIT License
3 stars 1 forks source link

sgf-viewer: Fix ToC anchor regression #110

Closed tomtseng closed 1 month ago

tomtseng commented 1 month ago

Fixes #108

Bug: Clicking on an entry in the table of contents should update the the URL to the anchor associated with that entry, but #103 introduced a new external table-of-contents library that no longer does this.

Fix: The table-of-contents library actually handles this automatically if the anchor is placed on the <h{1..6}> tag (from which the table of contents is generated), so I've moved the anchors from <div>s onto <h{1..6}>s.

netlify[bot] commented 1 month ago

Deploy Preview for goattack ready!

Name Link
Latest commit 39e870173856e9934289095d7305ef62e7d2618c
Latest deploy log https://app.netlify.com/sites/goattack/deploys/66493af30eccce0008aefc16
Deploy Preview https://deploy-preview-110--goattack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 98 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.