Closed tomtseng closed 5 months ago
Name | Link |
---|---|
Latest commit | 06a5239bd3ddc596feb931a889cc3f6e3ae55505 |
Latest deploy log | https://app.netlify.com/sites/goattack/deploys/666280443b8f98000830c78c |
Deploy Preview | https://deploy-preview-123--goattack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 96 (🔴 down 2 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
Fixes issue #12.
Issue: Navigating directly to an anchor link does not work on Chrome.
Diagnosis: Chrome issue that interacts with svelte-toc. https://github.com/janosh/svelte-toc/issues/57
svelte-toc
(the table of contents library) scrolls the ToC as the page is scrolled. That is, if your ToC is so long as to have its own scroll bar, if you scroll way down to the last heading on the page, the ToC div will also automatically scroll to its bottom.svelte-toc
does this by listening forscrollend
events and then making the ToC scroll to whatever the main page is looking at.scroll-behavior: smooth
, navigating directly to an anchor link fires severalscrollend
events upon page load. (I'm not sure why.)scrollend
events cause the ToC to scroll, which cancels the scroll of the main page body to the anchor.Potential fixes (besides waiting to see if the
svelte-toc
maintainer figures out a way to work around this):svelte-toc
for a second until the initialscrollend
events have presumably passed (this is what I chose in this PR)svelte-toc
's auto-scroll (via itskeepActiveTocItemInView
flag). This is mostly OK but would affect our sections with very long ToCs (e.g., "training sample games") and people using very short screensChanges
svelte-toc
<GameList />
s next to each Go board are dynamically loaded and shift the layout. To fix this, I add filler rows to the<Game List />
until the actual games are populated.