search

AlignmentResearch / KataGoVisualizer

MIT License
3 stars 1 forks source link

Docker compose: Run Jupyter by default and expose port #37

Closed AdamGleave closed 1 year ago

AdamGleave commented 1 year ago

Quality of life improvement to docker-compose.yml to start Jupyter notebook automatically (no need to docker exec and run it manually), and expose the port (no need to mess around with extra port forwarding or ngrok; just need to do SSH forwarding after this).

netlify[bot] commented 1 year ago

Deploy Preview for goattack canceled.

Name Link
Latest commit d49c0f0211f98a27b6846fb3e0802340fa5ad8e0
Latest deploy log https://app.netlify.com/sites/goattack/deploys/63ae535526a30c00081a0c0c
UFO-101 commented 1 year ago

Btw I guess you don't use VSCode cause we already have a devcontainer setup for that. What editor do you use?

tomtseng commented 1 year ago

We should update the notebooks/README.md — I wrote some stuff for how to launch the notebooks without VSCode there, but I didn't realize that there was already this docker-compose file for launching the notebooks more conveniently

AdamGleave commented 1 year ago

Thanks for the review, team.

@tomtseng I've updated the README now, thanks for catching that.

@UFO-101 I've updated comment to explain why binding to 127.0.0.1, and to use docker ps instead. I usually use PyCharm, but was just connecting to the Jupyter notebooks directly. Nothing against VSCode, but seems desirable to have an editor-agnostic workflow.