search

AlignmentResearch / KataGoVisualizer

MIT License
3 stars 1 forks source link

Add error bars to win-rate-vs-visits #39

Closed ed1d1a8d closed 1 year ago

ed1d1a8d commented 1 year ago

Have updated the overleaf with these error bar plots.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

netlify[bot] commented 1 year ago

Deploy Preview for goattack canceled.

Name Link
Latest commit 7aeed9bb65abcf3db6f79a0443ac46196ec72825
Latest deploy log https://app.netlify.com/sites/goattack/deploys/63b3eca1aac1580008becab7
AdamGleave commented 1 year ago

Thanks for adding support for this, Tony! Comments mostly nitpicky. Only one that seems like potential correctness issue is missing method="beta" in one confint call (but there may well be a good reason for this I'm not seeing). Please request re-review once comments addressed.

ed1d1a8d commented 1 year ago

Thanks for the review Adam. Fixed the nits and requested a review again.