search

AlignmentResearch / KataGoVisualizer

MIT License
3 stars 1 forks source link

Fix .devcontainer config. Add adv-training figure plotting code. #5

Closed UFO-101 closed 1 year ago

UFO-101 commented 1 year ago

Note I've changed

"font.size": 9,

to

"font.size": 10,
"font.weight": 'medium'

As I think this matches the font used in the rest of the paper.

UFO-101 commented 1 year ago

Thanks for getting around to this one. A couple comments:

  1. Could you adjust the training curve plot to avoid the SettingWithCopyWarning error?
  2. Could you fix up the lint errors as well?

Fixed. I've also committed all the figures with updated font size.

ed1d1a8d commented 1 year ago

Cool thanks for making the changes. LGTM now, will merge.